NextJS: Fix default next image loader when src has params#24187
Merged
valentinpalkovic merged 6 commits intoOct 5, 2023
Conversation
json-betsec
requested review from
kasperpeulen,
valentinpalkovic and
yannbf
as code owners
kasperpeulen
added
bug
ci:normal
ndelangen
changed the title
ndelangen
approved these changes
Sep 19, 2023
Member
|
@json-betsec did you do the manual test yourself? Could you do a final pass/check before I merge this? What do you think the risk of the PR is? |
Contributor
Author
I did a final check and this PR is good to go
I think this PR is very low risk
Absolutely! NOTE: I do think this file could just be: import type * as _NextImage from 'next/image';
export const defaultLoader = ({ src }: _NextImage.ImageLoaderProps) => {
return src;
};Which could be considered, but hey, to make this release, this PR can be good to merge too! |
This was referenced Oct 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24104
What I did
This PR fixes a bug in
@storybook/nextjswhich malforms URLs with search parameters in them given tonext/image.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Couldn't find any existing tests to add to.
Manual testing
next/imagewith a url that specifies query parametersDocumentation
No documentation updates were needed.
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>